Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReleaseCandidate releases feature #7

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

andreslucena
Copy link
Member

@andreslucena andreslucena commented Jul 16, 2024

Until now, the decidim-releaser script only was working for Patch versions (i.e. from v0.28.0 to v0.28.1).

This PR introduces the feature to make Release Candidates using this same tool (i.e. from v0.29.0.dev to v0.29.0.rc1).

For doing that, what I've done is:

  1. Extract the Patch code to its own class (ReleasePatchVersion)
  2. Make a ReleaseCandidateVersion class
  3. Move the common logic to the ReleaserUtils module

After this is merged, the next iteration would be to have a new class from ReleaseMinorVersion (from v0.29.0.rcX to v0.29.0)

As it is specially tricky to actually run this script without making a release, I can confirm that I've used this to create the branches for:

To check that I didn't break anything with the ReleasePatchVersion refactor, I've used this to create the branches for:

I think this is ready for a merge.

@andreslucena andreslucena changed the title Run webpack rake task for v0.27 Add ReleaseCandidate releases feature Jul 16, 2024
@andreslucena andreslucena marked this pull request as ready for review July 16, 2024 16:39
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, and i think is good to go.


To update, follow these steps:

### 1.1. Update your Gemfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have the policy of one Decidim version, has one ruby version, i would add here also the Upgrade ruby step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants